samples: tflite_ethosu: fix compile errors #88218
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: Neural Networks
area: C Library
github-actions
bot
requested review from
aescolar,
cfriedt,
kartben,
keith-packard,
laurenmurphyx64,
nashif,
stephanosio and
XenuIsWatching
With gcc command-line options -nostartfiles or -nostdlib, the gcc built-in object files crti.o/crtn.o which implement _init/_fini won't get linked in automatically and will cause undefined reference to _fini error when exit is invoked. This is fixed by providing one dummey _fini to let linker pass. Signed-off-by: Chun-Chieh Li <[email protected]>
Add header file stdint.h so that fixed width integer type e.g. uint8_t can use without compile error. Signed-off-by: Chun-Chieh Li <[email protected]>
It is unsafe to pass raw buffer as thread stack. Instead, use canonical K_THREAD_STACK_DEFINE or friends to define thread stack. Signed-off-by: Chun-Chieh Li <[email protected]>
ccli8
force-pushed
the
samples_tflm_ethosu_fix_error
branch
from
1483485 to
c5f6668
Compare
|
Hi, please take a look. |
|
This pull request has been marked as stale because it has been open (more than) 60 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 14 days. Note, that you can always re-open a closed pull request at any time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tries to fix some compile errors in the
tflite_ethosusample, including:_finisymbol on invoking exit() for newlib libcuint8_ttypeK_THREAD_STACK_DEFINEor friends instead of raw buffer